Remove dependency on setuptools #3221
Conversation
ssbarnea
force-pushed
the
rm/setuptools
branch
2 times, most recently
from
c3f5e3b to
603fdd8
Compare
setup.cfg
Outdated
| @@ -73,14 +73,15 @@ install_requires = | |||
| cookiecutter >= 1.7.3 # dependency issues in older versions | |||
| dataclasses; python_version<"3.7" | |||
| enrich >= 1.2.5 | |||
| importlib-metadata<2; python_version<="3.7" | |||
There was a problem hiding this comment.
Why isn't this listed among constraints?
There was a problem hiding this comment.
That is because pip-tools bugs/limitations. I am considering removing the constraints soon unless someone has time to split them python version. Even if we split them per python versions, we will also need one for linux and non linux.
Fixing the deps/constraints is not as easy as it seams. Happy to discuss that but is outside the scope of that PR.
There was a problem hiding this comment.
This appears to cause problems when trying to install ansible-core + molecule + an openstack component (ex. os-net-config) via constraints when installing under centos8 (e.g. 3.6). importlib-metadata 4.8 works, what is the specific reason to lock it to 2?
src/molecule/__init__.py
Outdated
| @@ -25,8 +25,8 @@ | |||
| __metaclass__ = type | |||
|
|
|||
| try: | |||
| import pkg_resources | |||
| import importlib_metadata | |||
There was a problem hiding this comment.
This shouldn't be a part of try-except because it's clearly listed as a dependency.
| import importlib_metadata |
There was a problem hiding this comment.
I do not fully remember all the reasons why we had this approach but I think that it was something related to running unittest without installing the package. I will try to remove and see what happens.
src/molecule/__init__.py
Outdated
|
|
||
| __version__ = pkg_resources.get_distribution("molecule").version | ||
| __version__ = importlib_metadata.version("molecule") # type: ignore | ||
| except Exception: |
There was a problem hiding this comment.
I don't think that with importlib-metadata we should be having a catch-all handler. Let's do
| except Exception: | |
| except importlib_metadata.PackageNotFoundError: |
src/molecule/__init__.py
Outdated
|
|
||
| __version__ = pkg_resources.get_distribution("molecule").version | ||
| __version__ = importlib_metadata.version("molecule") # type: ignore |
There was a problem hiding this comment.
Plz use specific ignores rather than ignoring everything.
| __version__ = importlib_metadata.version("molecule") # type: ignore | |
| __version__ = importlib_metadata.version("molecule") # type: ignore[a-specific-problem-id] |
ssbarnea
force-pushed
the
rm/setuptools
branch
from
603fdd8 to
f7baefa
Compare
ssbarnea
force-pushed
the
rm/setuptools
branch
from
f7baefa to
8449257
Compare
Fixes: #3219